Calendar event_add-compiled.js is not minimized

[Kirby]

event_add-compiled.js is not minimized, this does cause unnecessary data transfer

 

[Naz]

This might actually be more of an issue with XF's release builder and minifying compiled rollup bundles. I'll look in to it.

 

[Kirby]

I've used

{
    "additional_files": [
        "js/nf/calendar/event_add.js",
        "js/nf/calendar/fullcalendar.js",
        "js/nf/calendar/gcal.js",
        "js/nf/calendar/geocomplete.js",
        "js/nf/calendar/moment.js",
        "js/nf/calendar/timepicker.js",
        "src/addons/SV/Utils/"
    ],
    "minify": [
        "js/nf/calendar/event_add.js",
        "js/nf/calendar/fullcalendar.js",
        "js/nf/calendar/gcal.js",
        "js/nf/calendar/geocomplete.js",
        "js/nf/calendar/moment.js",
        "js/nf/calendar/timepicker.js"
    ],
    "rollup": {
        "js/nf/calendar/event_add-compiled.js": [
            "js/nf/calendar/timepicker.min.js",
            "js/nf/calendar/event_add.min.js"
        ]
    }
}

in accorance with Development tools - XenForo 2.0 Documentation to rebuild the Add-on and this seems to work fine.

 

[Naz]

Thanks, my build.json is a bit different but I've resolved this now.