Rosters Not a Bug Phrases are not assigned an addon id

[SeToY]

For example the phrase nf_rosters_roster_field_title.joinDate has no addon id assigned. I assume it's the same for the others as well. A couple I identified:

nf_rosters_roster_field_title.joinDate
nf_rosters_roster_field_desc.joinDate
nf_rosters_roster_field_title.promoDate
nf_rosters_roster_field_desc.promoDate

 

[Naz]

It's because those fields are now custom roster fields so this is expected.

They used to be default fields but it made more sense to ship them as custom fields so users can remove or edit them where applicable.

 

[SeToY]

So this seems to be a XF bug? Since when no addon id is assigned I imagine they're not getting cleaned up when the responsible addon is uninstalled?

 

[Naz]

It's not an XF bug either. All add-ons that implement custom fields do the same thing (including XFRM and XFMG) otherwise the phrases would get overwritten when the add-on gets updated.

It's up to the add-on to clean up on uninstall which admittedly, Rosters doesn't actually seem to do so that is something I need to look in to...